-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWA URL Rewriting #110
PWA URL Rewriting #110
Conversation
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe BREAKING CHANGE: product URLs no longer match static pattern .*/product/<sku> but can instead be localized and customized for any pattern
c75bb39
to
d99c98b
Compare
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe BREAKING CHANGE: category URLs no longer match static pattern /category/<categoryUniqueId> but can instead be localized and customized for any pattern
f60ac67
to
fe640f9
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
fe640f9
to
5d029b9
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
5d029b9
to
3269033
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
3269033
to
127fa3f
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
8936f60
to
9398dd7
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
9398dd7
to
14a54cf
Compare
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
0a918d8
to
128663a
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
128663a
to
1c03b76
Compare
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
1c03b76
to
d1d76c9
Compare
LinkParser.parseLink() should modified |
- cleanup unused parameters of constructors in tests - safety checks
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
d1d76c9
to
0ae596f
Compare
Done ✔️ Also changed the category slug to the deepest category only |
@@ -19,7 +19,7 @@ import { ShellModule } from './shell/shell.module'; | |||
ShellModule, | |||
AppRoutingModule, | |||
QuotingRoutingModule, | |||
AppNotFoundRoutingModule, | |||
AppLastRoutingModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why its not in AppRoutingModule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, the new category and product route definitions could also reside in the app-routing, but I figured, it's better to have them somewhere else close together, because the order of those dynamic routes is important.
Currently every product route (with -sku123-cat456
) would also match the category route, so it must come before the category route.
One could also think of a route that matches nearly everything and if it resides in the app-routing, it will also capture all routes by pages added with schematics or extensions (as they are added at the bottom of those lists.)
- moved ProductRoutePipe to core/routing/product - match incoming URLs for products with Angular UrlMatcher and RegExp pattern - improved typing of ProductRoutePipe
…#110) - moved CategoryRoutePipe to core/routing/category - match incoming URLs for categories with Angular UrlMatcher and RegExp pattern - improved typing of CategoryRoutePipe
PR Type
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
URLs in PWA shopping experience are fairly static and not easily customizable.
Issue Number:
Closes #33
Closes #11
What Is the New Behavior?
URL rewriting (Wiki)
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information